Added basic yamux connection upgrade #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
sb-comms-yamux
branch
4 times, most recently
from
1a25279
to
e418555
Compare
sdbondi
commented
Dec 5, 2019
sdbondi
force-pushed
the
sb-comms-yamux
branch
8 times, most recently
from
f5f490a
to
030391f
Compare
|
Looks good; but would you mind adding your HOWTO to the README file? People won't know to run |
sdbondi
force-pushed
the
sb-comms-yamux
branch
5 times, most recently
from
0415cf2
to
f8b5574
Compare
sdbondi
commented
Dec 10, 2019
| @@ -35,6 +35,20 @@ to generate the documentation. The generated html sits in `target/doc/`. Alterna | |||
|
|
|||
| See [RFC-0110/CodeStructure](./RFC/src/RFC-0010_CodeStructure.md) for details on the code structure and layout. | |||
|
|
|||
| ### Git submodules | |||
There was a problem hiding this comment.
@CjS77 Added this section
Yamux provides multiplexing over a ordered reliable connection (e.g. TCP). More info: https://github.com/hashicorp/yamux/blob/master/spec.md - This is working from a fork of yamux (develop branch), where the upgrade to futures 0.3.x is close to complete - Made a TcpStream wrapper struct which implements futures `AsyncWrite` and `AsyncRead` to reduce the tie in to tokio - _Side note:_ investigated upgrading to futures 0.3.x however there ended up being a few external libraries which are locked to alpha futures. This is WIP for tonic (hyperium/tonic#163) and tower (no PR - we may be able to pretty easily remove this dependency)
sdbondi
force-pushed
the
sb-comms-yamux
branch
from
f8b5574
to
3c9774e
Compare
CjS77
added a commit
that referenced
this pull request
Dec 10, 2019
Merge pull request #1096 Yamux provides multiplexing over a ordered reliable connection (e.g. TCP). More info: https://github.com/hashicorp/yamux/blob/master/spec.md Added yamux as a git submodule. Run git submodule init and git submodule update --recursive --remote. Optionally, run git config submodule.recurse true to enable updating all submodules on pull. This is working from a fork of yamux (develop branch), where the upgrade to futures 0.3.x is close to complete Made a TcpStream wrapper struct which implements futures AsyncWrite and AsyncRead to reduce the tie in to tokio Side note: investigated upgrading to futures 0.3.x however there ended up being a few external libraries which are locked to alpha futures. This is WIP for tonic (hyperium/tonic#163) and tower (no PR - we may be able to pretty easily remove this dependency)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Yamux provides multiplexing over a ordered reliable connection (e.g. TCP).
More info: https://github.com/hashicorp/yamux/blob/master/spec.md
git submodule initandgit submodule update --recursive --remote. Optionally, rungit config submodule.recurse trueto enable updating all submodules on pull.upgrade to futures 0.3.x is close to complete
AsyncWriteandAsyncReadto reduce the tie in to tokiotokio 0.2hyperium/tonic#163) and tower (no PR - we may be able to pretty easily remove this dependency)Motivation and Context
Partial #1049
How Has This Been Tested?
Unit tests
Types of changes
Checklist:
developmentbranchcargo-fmt --allbefore pushing